New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-2751: Using related images naming scheme #1522
Conversation
need change the variable name in Makefile as well? cluster-logging-operator/Makefile Line 195 in 576cf90
|
I do not believe so, @vimalk78. Only the name of the image had changed, not the image's source. |
576cf90
to
40afb52
Compare
Actually, I think you're right, @vimalk78. I didn't realize exactly how the test framework worked. |
40afb52
to
25c599a
Compare
/retest |
25c599a
to
e7c204c
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, Red-GV The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@Red-GV: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR adds the images under the
relatedImages
section./cc @syedriko
/assign @jcantrill
Links