Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-2751: Using related images naming scheme #1522

Merged
merged 1 commit into from Jun 25, 2022

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented Jun 21, 2022

This PR adds the images under the relatedImages section.

/cc @syedriko
/assign @jcantrill

Links

@openshift-ci openshift-ci bot requested a review from syedriko June 21, 2022 13:32
@Red-GV Red-GV marked this pull request as draft June 21, 2022 13:47
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2022
@Red-GV Red-GV marked this pull request as ready for review June 23, 2022 12:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2022
@vimalk78
Copy link
Contributor

need change the variable name in Makefile as well?

VECTOR_IMAGE=$(IMAGE_LOGGING_VECTOR) \

@Red-GV
Copy link
Contributor Author

Red-GV commented Jun 23, 2022

I do not believe so, @vimalk78. Only the name of the image had changed, not the image's source.

@Red-GV
Copy link
Contributor Author

Red-GV commented Jun 23, 2022

Actually, I think you're right, @vimalk78. I didn't realize exactly how the test framework worked.

@Red-GV
Copy link
Contributor Author

Red-GV commented Jun 23, 2022

/retest

@jcantrill
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, Red-GV

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2022
@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 02c8c1b and 8 for PR HEAD e7c204c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2022

@Red-GV: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit ab90987 into openshift:master Jun 25, 2022
@Red-GV Red-GV deleted the 5.5-related-images branch August 22, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants