Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-2869: Simplify sending audit-logs to LokiStack #1583

Closed
wants to merge 1 commit into from
Closed

LOG-2869: Simplify sending audit-logs to LokiStack #1583

wants to merge 1 commit into from

Conversation

xperimental
Copy link
Contributor

@xperimental xperimental commented Jul 29, 2022 •
edited by openshift-ci bot

Description

This PR simplifies the configuration needed for forwarding audit-logs into LokiStack log store.

Links

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xperimental
Once this PR has been reviewed and has the lgtm label, please assign periklis for approval by writing /assign @periklis in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xperimental
Copy link
Contributor Author

/hold

This will conflict with #1578 , I'd suggest we try to get that one merged before. I have incorporated the changes from that PR into this one as well, so re-basing should be easy.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2022
@xperimental xperimental force-pushed the lokistack-forward-audit-option branch from 6f45035 to 24e9397 Compare July 30, 2022 23:29
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 30, 2022
@xperimental xperimental force-pushed the lokistack-forward-audit-option branch from 24e9397 to f808996 Compare August 1, 2022 09:01
@xperimental
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2022

@xperimental: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xperimental
Copy link
Contributor Author

/unhold

Rebase happened and all checks are happy now. 🙂

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@jcantrill
Copy link
Contributor

/hold

I would like for us to review the API again.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@xperimental
Copy link
Contributor Author

/close

Superseded by #1587

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 4, 2022
@openshift-merge-robot
Copy link
Contributor

@xperimental: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Aug 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

@xperimental: Closed this PR.

In response to this:

/close

Superseded by #1587

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xperimental xperimental deleted the lokistack-forward-audit-option branch August 4, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill Awaiting requested review from jcantrill

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xperimental @jcantrill @openshift-merge-robot