Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-2843: tls.key and tls.cert not in fluentd real configuration when forwarding logs using syslog tls #1643

Merged
merged 1 commit into from Sep 27, 2022

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Sep 14, 2022

Description

Implement support for client-side certificate and key for the remote_syslog fluentd plugin

/cc @vimalk78
/assign @jcantrill

Links

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1ff4c20 and 2 for PR HEAD e1750be in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a83cd4f and 1 for PR HEAD e1750be in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1a555e6 and 0 for PR HEAD e1750be in total

@syedriko
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@syedriko
Copy link
Contributor Author

/test e2e

@syedriko
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b4c8681 and 2 for PR HEAD e1750be in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 64a0d47 into openshift:master Sep 27, 2022
@syedriko syedriko deleted the syedriko_log_2843 branch January 19, 2023 00:41
@syedriko
Copy link
Contributor Author

/cherrypick release-5.5

@openshift-cherrypick-robot

@syedriko: new pull request created: #1835

In response to this:

/cherrypick release-5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants