Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-2843, take two. Added client key passphrase #1669

Merged

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Oct 3, 2022

Description

A fix for the fix for LOG-2843, added support for client key passphrase missed in the original fix.

/cc @vimalk78
/assign @jcantrill

Links

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2022
@syedriko
Copy link
Contributor Author

syedriko commented Oct 3, 2022

/test e2e

1 similar comment
@syedriko
Copy link
Contributor Author

syedriko commented Oct 4, 2022

/test e2e

@jcantrill
Copy link
Contributor

/retest

@syedriko
Copy link
Contributor Author

/test e2e

@jcantrill
Copy link
Contributor

/lgtm

@jcantrill jcantrill added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d97f8c8 and 2 for PR HEAD 8e8d259 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 23458f5 and 1 for PR HEAD 8e8d259 in total

@syedriko
Copy link
Contributor Author

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2022

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4c57789 into openshift:master Oct 14, 2022
@syedriko syedriko deleted the syedriko_log_2843_passphrase branch January 19, 2023 00:37
@syedriko
Copy link
Contributor Author

/cherrypick release-5.5

@openshift-cherrypick-robot

@syedriko: #1669 failed to apply on top of branch "release-5.5":

Applying: LOG-2843, take two. Added client key passphrase
Using index info to reconstruct a base tree...
M	internal/generator/fluentd/output/syslog/syslog.go
Falling back to patching base and 3-way merge...
Auto-merging internal/generator/fluentd/output/syslog/syslog.go
CONFLICT (content): Merge conflict in internal/generator/fluentd/output/syslog/syslog.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 LOG-2843, take two. Added client key passphrase
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants