Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1706134: Allowing scale up past 3 nodes for ES Cr #170

Conversation

ewolinetz
Copy link
Contributor

@ewolinetz
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 3, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2019
@josefkarasek
Copy link

/lgtm

@josefkarasek
Copy link

josefkarasek commented May 6, 2019

Looking good, @ewolinetz.

For future plans @lukas-vlcek and I have tried to come up with possible topologies based on number of nodes:

1 - 3: n CDM
4 - 9: 3 CDM + (n - 3) CD
10 and more: 3 M + 3 C + (n - 6) D

n = nodeCount

Topologies with n > 9 would have 3 client-only nodes, which should make the whole cluster more stable than clusters of size between 4 and 9 nodes, but such clusters would have decreased data capacity by having 3 extra (client) nodes, which can't store data.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, josefkarasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,josefkarasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill
Copy link
Contributor

Please remove the role names from the artifacts as this will affect migrating to topolgies > 3

@ewolinetz
Copy link
Contributor Author

@jcantrill i need to make those changes in EO, i'll open a pr to address that as part of this fix

@ewolinetz
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2019
@ewolinetz
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 3fbac4a into openshift:master May 6, 2019
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
…_fix_2

Bug 1706134: Allowing scale up past 3 nodes for ES Cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants