Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-5.5] LOG-3207 vector tag fix cherry-pick release-5.5 #1709

Closed

Conversation

cahartma
Copy link
Contributor

@cahartma cahartma commented Oct 19, 2022

Description

clone of LOG-3145
Remove dot from the value of the tag field in vector

/cc @vimalk78 @syedriko
/assign @jcantrill

Manual cherry-pick of 43798b6b

Links

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cahartma
Once this PR has been reviewed and has the lgtm label, please assign jcantrill for approval by writing /assign @jcantrill in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cahartma
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2022

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cahartma
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2022
@cahartma
Copy link
Contributor Author

Closed as will not be fixing the tag field.  It was never part of our model and is therefor a bug that it exists.

@cahartma cahartma closed this Oct 26, 2022
@cahartma cahartma deleted the log-3145-release-5.5 branch October 26, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants