Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-1796:Add multi-line exception detection for Vector collector #1754

Merged
merged 1 commit into from Nov 28, 2022
Merged

LOG-1796:Add multi-line exception detection for Vector collector #1754

merged 1 commit into from Nov 28, 2022

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Nov 14, 2022 •
edited

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

Description

/cc
/assign

/cherry-pick

Links

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vparfonov
Copy link
Contributor Author

/test all

@vparfonov vparfonov marked this pull request as ready for review November 14, 2022 20:22
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2022
@vparfonov
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2022
@vparfonov
Copy link
Contributor Author

/assign

@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@vparfonov vparfonov marked this pull request as draft November 16, 2022 11:20
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2022
@vparfonov vparfonov marked this pull request as ready for review November 17, 2022 08:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2022
@openshift-ci openshift-ci bot requested a review from cahartma November 17, 2022 08:32
jcantrill
jcantrill requested changes Nov 17, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
olm_deploy/scripts/env.sh Outdated Show resolved Hide resolved
test/functional/normalization/multiline_exception_vector_test.go Outdated Show resolved Hide resolved
@vparfonov vparfonov marked this pull request as draft November 17, 2022 23:01
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2022
@vparfonov
Copy link
Contributor Author

/test-functional

@vparfonov
Copy link
Contributor Author

/test functional

@vparfonov
LOG-1796:Add multi-line exception detection for Vector collector
f5e5bbf 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vparfonov vparfonov marked this pull request as ready for review November 18, 2022 15:54
@vparfonov vparfonov requested review from jcantrill and removed request for vimalk78, syedriko and cahartma November 18, 2022 15:54
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2022

@vparfonov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-previous f5e5bbf link false /test e2e-ocp-previous
ci/prow/e2e-ocp-next f5e5bbf link false /test e2e-ocp-next

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vparfonov
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022
jcantrill
jcantrill approved these changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

test/functional/normalization/multiline_exception_test.go
if testfw.LogCollectionType == logging.LogCollectionTypeVector {
Expect(framework.WriteMessagesToApplicationLog(strings.Join(buffer, "\n"), 1)).To(Succeed())
} else {
Expect(framework.WriteMessagesToNamespace(strings.Join(buffer, "\n"), appNamespace, 1)).To(Succeed())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for vector as long as it's the same ns as the test pod. And then maybe you could enable the other tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for vector as long as it's the same ns as the test pod. And then maybe you could enable the other tests

I checked, these tests not work for vector without modification related to the namespace name

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2022
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7832b72 into openshift:master Nov 28, 2022
@vparfonov vparfonov deleted the log1796 branch November 28, 2022 14:45
@vparfonov vparfonov mentioned this pull request Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill approved these changes

@syedriko syedriko Awaiting requested review from syedriko

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees

@vparfonov vparfonov

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/5.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vparfonov @jcantrill @openshift-merge-robot