LOG-3302: Update scc to desired #1806
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cherrypick master |
|
@jcantrill: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-5.5 |
|
@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcantrill: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| to.Labels = from.Labels | ||
| to.Priority = from.Priority | ||
| to.AllowPrivilegedContainer = from.AllowPrivilegedContainer | ||
| to.DefaultAddCapabilities = from.DefaultAddCapabilities | ||
| to.RequiredDropCapabilities = from.RequiredDropCapabilities | ||
| to.AllowedCapabilities = from.AllowedCapabilities | ||
| to.AllowHostDirVolumePlugin = from.AllowHostDirVolumePlugin | ||
| to.Volumes = from.Volumes | ||
| to.AllowedFlexVolumes = from.AllowedFlexVolumes | ||
| to.AllowHostNetwork = from.AllowHostNetwork | ||
| to.AllowHostPorts = from.AllowHostPorts | ||
| to.AllowHostPID = from.AllowHostPID | ||
| to.AllowHostIPC = from.AllowHostIPC | ||
| to.DefaultAllowPrivilegeEscalation = from.DefaultAllowPrivilegeEscalation | ||
| to.AllowPrivilegeEscalation = from.AllowPrivilegeEscalation | ||
| to.SELinuxContext = from.SELinuxContext | ||
| to.RunAsUser = from.RunAsUser | ||
| to.SupplementalGroups = from.SupplementalGroups | ||
| to.FSGroup = from.FSGroup | ||
| to.ReadOnlyRootFilesystem = from.ReadOnlyRootFilesystem | ||
| to.Users = from.Users | ||
| to.Groups = from.Groups | ||
| to.SeccompProfiles = from.SeccompProfiles | ||
| to.AllowedUnsafeSysctls = from.AllowedUnsafeSysctls | ||
| to.ForbiddenSysctls = from.ForbiddenSysctls | ||
|
|
There was a problem hiding this comment.
can we replace this block with *to=*from if all fields are to be copied?
There was a problem hiding this comment.
SCCs don't have a "spec" field, they live off the root of the type. The only change we possibly could make is to use reflection over the fields
There was a problem hiding this comment.
agree. a *to=*from would copy more fields than we need.
|
/lgtm |
|
@jcantrill: new pull request created: #1815 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcantrill: new pull request created: #1816 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This PR:
Links