LOG-3609: Fix collector restart after creation #1848
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vimalk78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
vimalk78
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@vimalk78: This pull request references LOG-3609 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vimalk78: This pull request references LOG-3609 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/lgtm |
|
/retest |
Collector gets restarted if collector is started without waiting for waiting for trusted ca-bundle config map to get created. Modified the reconcile logic to wait for trusted ca-bundle to get created. Log Collector SCC desires 4 volumes `"configMap"`,`"emptyDir"`,`"projected"`,`"secret"`, but CRC container adds another volume for `"hostpath"`. The SCC comparator does a reflect comparison, which fails because there is one extra Volume. Fixed the SCC comparator to check for desired volumes only.
vimalk78
force-pushed
the
fix-collector-restart
branch
from
e9c2e01
to
413f4dc
Compare
|
/retest |
1 similar comment
|
/retest |
vimalk78
force-pushed
the
fix-collector-restart
branch
from
7205cb7
to
413f4dc
Compare
|
@vimalk78: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-5.6 |
|
@vimalk78: new pull request created: #1856 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Collector gets restarted if collector is started without waiting for waiting for trusted ca-bundle config map to get created.
Modified the reconcile logic to wait for trusted ca-bundle to get created.
Log Collector SCC desires 4 volumes
"configMap","emptyDir","projected","secret", but CRC container adds another volume for"hostpath".The SCC comparator does a reflect comparison, which fails because there is one extra Volume.
Fixed the SCC comparator to check for desired volumes only.
/cc
/assign
/cherry-pick
Links