Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-2854: Update go version to 1.18 #1855

Merged
merged 1 commit into from
Feb 10, 2023
Merged

LOG-2854: Update go version to 1.18 #1855

merged 1 commit into from
Feb 10, 2023

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • Updates to project to use golang 1.18

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2023 •
edited by openshift-ci bot

@jcantrill: This pull request references LOG-2854 which is a valid jira issue.

In response to this:

Description

This PR:

  • Updates to project to use golang 1.18

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Feb 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@jcantrill
Copy link
Contributor Author

/retest

@cahartma
Copy link
Contributor

cahartma commented Feb 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 99515a9 and 2 for PR HEAD 708b621 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 10, 2023

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit fd425a6 into openshift:master Feb 10, 2023
@jcantrill jcantrill deleted the log2854 branch February 10, 2023 03:12
@jcantrill
Copy link
Contributor Author

/cherrypick release-5.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 10, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jcantrill: new pull request created: #1859

In response to this:

/cherrypick release-5.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanconway alanconway Awaiting requested review from alanconway

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@cahartma cahartma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile A Dockerfile.in sync is needed with midstream release/5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcantrill @openshift-ci-robot @cahartma @openshift-cherrypick-robot @openshift-merge-robot