Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-3499: add volume mount for /var/log/oauth-server/ #1871

Merged
merged 1 commit into from Feb 21, 2023

Conversation

vparfonov
Copy link
Contributor

Description

This PR:

/cc
/assign @jcantrill

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2023

@vparfonov: This pull request references LOG-3499 which is a valid jira issue.

In response to this:

Description

This PR:

/cc
/assign @jcantrill

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/cherry-pick release-5.6

@openshift-cherrypick-robot

@vparfonov: once the present PR merges, I will cherry-pick it on top of release-5.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-5.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/cherry-pick release-5.5

@openshift-cherrypick-robot

@vparfonov: once the present PR merges, I will cherry-pick it on top of release-5.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/cherry-pick release-5.4

@openshift-cherrypick-robot

@vparfonov: once the present PR merges, I will cherry-pick it on top of release-5.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/assign @jcantrill

Copy link
Contributor

@cahartma cahartma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@vimalk78
Copy link
Contributor

Please add a functional test case to capture these logs.

@jcantrill
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 21, 2023

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-cherrypick-robot

@vparfonov: new pull request created: #1879

In response to this:

/cherry-pick release-5.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@vparfonov: new pull request created: #1881

In response to this:

/cherry-pick release-5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@vparfonov: #1871 failed to apply on top of branch "release-5.4":

Applying: LOG-3499: add volume mount for /var/log/oauth-server/
Using index info to reconstruct a base tree...
A	internal/collector/collector.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): internal/collector/collector.go deleted in HEAD and modified in LOG-3499: add volume mount for /var/log/oauth-server/. Version LOG-3499: add volume mount for /var/log/oauth-server/ of internal/collector/collector.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 LOG-3499: add volume mount for /var/log/oauth-server/
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants