Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-3640: fix structured logs not being forwarded to all outputs #1906

Merged
merged 1 commit into from Mar 13, 2023

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • fixes parsed JSON messages not being sent to all outputs

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 11, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2023

@jcantrill: This pull request references LOG-3640 which is a valid jira issue.

In response to this:

Description

This PR:

  • fixes parsed JSON messages not being sent to all outputs

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor Author

/cherrypick master

@openshift-cherrypick-robot

@jcantrill: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2023
@jcantrill
Copy link
Contributor Author

/cherrypick release-5.5

@openshift-cherrypick-robot

@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.5 in a new PR and assign it to you.

In response to this:

/cherrypick release-5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2023

@jcantrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-next e8360ba link false /test e2e-ocp-next
ci/prow/e2e-ocp-previous e8360ba link false /test e2e-ocp-previous

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot

@jcantrill: new pull request created: #1909

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jcantrill: #1906 failed to apply on top of branch "release-5.5":

Applying: LOG-3640: fix structured logs not being forwarded to all outputs
Using index info to reconstruct a base tree...
M	internal/generator/fluentd/inputs_to_pipeline.go
M	test/framework/functional/cluster_log_forwarder.go
M	test/functional/outputs/multiple/multiple_test.go
Falling back to patching base and 3-way merge...
Auto-merging test/functional/outputs/multiple/multiple_test.go
Auto-merging test/framework/functional/cluster_log_forwarder.go
CONFLICT (content): Merge conflict in test/framework/functional/cluster_log_forwarder.go
Auto-merging internal/generator/fluentd/inputs_to_pipeline.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 LOG-3640: fix structured logs not being forwarded to all outputs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-5.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill deleted the log3640 branch March 13, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants