LOG-3767: fix structured logs not being forwarded to all outputs #1910
Conversation
|
@jcantrill: This pull request references LOG-3767 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jcantrill
force-pushed
the
log3767
branch
3 times, most recently
from
1a39335
to
8482f6b
Compare
There was a problem hiding this comment.
nit: typo in file name inputEs -> inputs
| func (f *CollectorFunctionalFramework) GetLogsFromElasticSearchIndex(outputName string, index string) (result string, err error) { | ||
| var buffer []string |
There was a problem hiding this comment.
nit: need new line before func
| log.V(4).Info("Returning", "logs", result) | ||
| return result, err | ||
| } | ||
| func (f *CollectorFunctionalFramework) ReadLogsFromElasticSearchIndex(outputName string, index string) ([]string, error) { |
There was a problem hiding this comment.
nit: need new line before func
|
/test functional |
2 similar comments
|
/test functional |
|
/test functional |
|
@jcantrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Description
This PR:
Links