LOG-3948: [Vector] No error message shown on collector pods when the syslog output url is wrong in CLF

[syedriko]

Description

Before this PR, when vector forwarded logs to a syslog endpoint, the scheme of the endpoint URL defaulted to 'tcp' (including 'tls') unless it was 'udp'. No error was produced for an invalid URL scheme.
With this PR, a URL scheme that is not 'tcp', 'tls' or 'udp', results in the status of the corresponding ClusterLogForwarder output set to False with an error message:

apiVersion: logging.openshift.io/v1
kind: ClusterLogForwarder
metadata:
  name: instance
  namespace: openshift-logging
spec:
  outputs:
  - name: rsyslog
    syslog:
      facility: local0
      rfc: RFC5424
      severity: informational
    type: syslog
    url: xyz://rsyslogd.syslog.svc.cluster.local:24224
...
status:
  outputs:
    rsyslog:
    - lastTransitionTime: "2023-04-14T21:27:26Z"
      message: 'invalid URL scheme: xyz'
      reason: Invalid
      status: "False"
      type: Ready

/cc @cahartma
/assign @jcantrill

Links

• JIRA: https://issues.redhat.com/browse/LOG-3948

[openshift-ci-robot]

@syedriko: This pull request references LOG-3948 which is a valid jira issue.

In response to this:

Description

Before this PR, when vector forwarded logs to a syslog endpoint, the scheme of the endpoint URL defaulted to 'tcp' (including 'tls') unless it was 'udp'. No error was produced for an invalid URL scheme.
This PR changes this so that the URL scheme is passed on to vector, unless it is 'tls', which is mapped to 'tcp'.
For an invalid scheme, vector now refuses to start, with an error message like this:

2023-04-14T19:22:36.455964Z ERROR vector::cli: Configuration error. error=unknown variant `xyz`, expected one of `tcp`, `udp`, `unix` for key `sinks.rsyslog`

/cc @cahartma
/assign @jcantrill

Links

• JIRA: https://issues.redhat.com/browse/LOG-3948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

Please add a validation so users get an earlier failure then a pod collector not starting. Ref: https://github.com/openshift/cluster-logging-operator/blob/master/internal/validations/clusterlogforwarder/validate_clusterlogforwarderspec.go#L255

[openshift-ci-robot]

@syedriko: This pull request references LOG-3948 which is a valid jira issue.

In response to this:

Description

Before this PR, when vector forwarded logs to a syslog endpoint, the scheme of the endpoint URL defaulted to 'tcp' (including 'tls') unless it was 'udp'. No error was produced for an invalid URL scheme.
With this PR, a URL scheme that is not 'tcp', 'tls' or 'udp', results in the status of the corresponding ClusterLogForwarder output set to False with an error message:

apiVersion: logging.openshift.io/v1
kind: ClusterLogForwarder
metadata:
 name: instance
 namespace: openshift-logging
spec:
 outputs:
 - name: rsyslog
   syslog:
     facility: local0
     rfc: RFC5424
     severity: informational
   type: syslog
   url: xyz://rsyslogd.syslog.svc.cluster.local:24224
...
status:
 outputs:
   rsyslog:
   - lastTransitionTime: "2023-04-14T21:27:26Z"
     message: 'invalid URL scheme: xyz'
     reason: Invalid
     status: "False"
     type: Ready

/cc @cahartma
/assign @jcantrill

Links

• JIRA: https://issues.redhat.com/browse/LOG-3948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

/hold
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcantrill]

/retest

[openshift-ci]

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jcantrill]

/hold cancel
/lgtm

[jcantrill]

/lgtm