[release-5.7] LOG-3945: Collector pods in CrashLoopBackOff with spaces in pipeline name

[Clee2691]

Description

This PR fixes the CrashLoopBackOff problem for the collector container when the ClusterLogForwarder spec's pipeline name contained spaces. This fix sanitizes pipeline names replacing spaces " ", dashes -, and dots . with underscores _.

Example:
pipeline with space -> pipeline_with_space
pipeline.with space.dot -> pipeline_with_space_dot

In addition to the above fix, I refactored most vector output's ComponentIDs to use the vector helper function, FormatComponentID() instead of strings.ToLower(), to improve code readability.

/cc @cahartma @vparfonov
/assign @jcantrill

/cherry-pick master

Links

• JIRA: https://issues.redhat.com/browse/LOG-3945

[openshift-ci-robot]

@Clee2691: This pull request references LOG-3945 which is a valid jira issue.

In response to this:

Description

This PR fixes the CrashLoopBackOff problem for the collector container when the ClusterLogForwarder spec's pipeline name contained spaces. This fix sanitizes pipeline names replacing spaces " ", dashes -, and dots . with underscores _.

Example:
pipeline with space -> pipeline_with_space
pipeline.with space.dot -> pipeline_with_space_dot

In addition to the above fix, I refactored most vector output's ComponentIDs to use the vector helper function, FormatComponentID() instead of strings.ToLower(), to improve code readability.

/cc @cahartma @vparfonov
/assign @jcantrill

/cherry-pick master

Links

• JIRA: https://issues.redhat.com/browse/LOG-3945

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

/approve
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jcantrill]

/retest

[jcantrill]

/retest

[jcantrill]

/retest

[Clee2691]

/retest

[jcantrill]

/lgtm

[jcantrill]

/hold cancel

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 26afcb4 and 2 for PR HEAD a85b2c2 in total

[Clee2691]

/retest

[openshift-ci]

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.