Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-3985: make spec.visualization.kibana.replicas optional on Kibana spec type #1967

Merged
merged 1 commit into from
Apr 25, 2023
Merged

LOG-3985: make spec.visualization.kibana.replicas optional on Kibana spec type #1967

merged 1 commit into from
Apr 25, 2023

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Apr 25, 2023 •
edited

Description

Currently, the spec.visualization.kibana.replicas field in the Kibana spec is mandatory, which means that if Kibana is not available, it can cause errors.
With this PR, spec.visualization.kibana.replicas field can be set to null or omit it entirely when Kibana is not needed. This will prevent the Kubernetes API server from raising errors when trying to validate the Kibana spec.

/cc
/assign

/cherry-pick

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-3985 which is a valid jira issue.

In response to this:

Description

/cc
/assign

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 25, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-3985 which is a valid jira issue.

In response to this:

Description

Currently, the spec.visualization.kibana.replicas field in the Kibana spec is mandatory, which means that if Kibana is not available, it can cause errors.
With this PR, spec.visualization.kibana.replicas field can be set to null or omit it entirely when Kibana is not needed. This will prevent the Kubernetes API server from raising errors when trying to validate the Kibana spec.

/cc
/assign

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov vparfonov force-pushed the log3985-5.7 branch 2 times, most recently from d916d31 to 67a81b0 Compare April 25, 2023 14:32
@vparfonov
Copy link
Contributor Author

/cherry-pick master

@openshift-cherrypick-robot
Copy link

@vparfonov: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
LOG-3985: make spec.visualization.kibana.replicas optional on Kibana …
67a81b0 
…spec type

Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
@jcantrill
Copy link
Contributor

/approve

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2023
@openshift-merge-robot openshift-merge-robot merged commit 025e65b into openshift:release-5.7 Apr 25, 2023
@vparfonov vparfonov deleted the log3985-5.7 branch April 25, 2023 16:21
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 25, 2023
Merged
@openshift-cherrypick-robot
Copy link

@vparfonov: new pull request created: #1968

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanconway alanconway alanconway requested changes

@cahartma cahartma Awaiting requested review from cahartma

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vparfonov @openshift-ci-robot @openshift-cherrypick-robot @jcantrill @alanconway @openshift-merge-robot