Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4039: logging-view-plugin not deployed when visualization is nil #1989

Conversation

cahartma
Copy link
Contributor

@cahartma cahartma commented May 4, 2023

Description

Critical bug fix for 5.7
The logging-view-plugin will not be deployed unless visualization is added to clusterlogging CR

/cc @Clee2691 @syedriko
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 4, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2023

@cahartma: This pull request references LOG-4039 which is a valid jira issue.

In response to this:

Description

Critical bug fix for 5.7
The logging-view-plugin will not be deployed unless visualization is added to clusterlogging CR

/cc @Clee2691 @syedriko
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from Clee2691 and syedriko May 4, 2023 15:15
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@Clee2691
Copy link
Contributor

Clee2691 commented May 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@jcantrill
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@jcantrill
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 902566b and 2 for PR HEAD 4cf1b35 in total

@cahartma cahartma force-pushed the LOG-4039-logging-view-plugin-not-created branch from 4cf1b35 to 4895eed Compare May 4, 2023 18:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@Clee2691
Copy link
Contributor

Clee2691 commented May 4, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 902566b and 2 for PR HEAD 4895eed in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2023

@cahartma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-target-minus-one 4895eed link false /test e2e-ocp-target-minus-one

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b9408e5 into openshift:release-5.7 May 4, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants