Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4146: Fix generation TLS configuration if insecureSkipVerify=true and no certificate, but other secrets exist #2042

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

vparfonov
Copy link
Contributor

Description

This PR fix generation configuration for Vector to apply the tls.insecureSkipVerify=true configuration even if the certificate is not added to the secret for Loki output, but other secrets exist. The following configuration will be added to the Vector config:

tls.verify_certificate = false
tls.verify_hostname = false

/cc @anpingli
/assign @jcantrill

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

…, no certificate, but secrets exist

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2023

@vparfonov: This pull request references LOG-4146 which is a valid jira issue.

In response to this:

Description

This PR fix generation configuration for Vector to apply the tls.insecureSkipVerify=true configuration even if the certificate is not added to the secret for Loki output, but other secrets exist. The following configuration will be added to the Vector config:

tls.verify_certificate = false
tls.verify_hostname = false

/cc @anpingli
/assign @jcantrill

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/assign @jcantrill

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-previous de23215 link false /test e2e-ocp-previous

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2023
@openshift-merge-robot openshift-merge-robot merged commit f2a4007 into openshift:release-5.6 Jun 6, 2023
@vparfonov vparfonov deleted the log4146 branch June 6, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants