Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4175: code cleanup to remove the certificate handling modifications made for LOG-1923 #2044

Merged
merged 1 commit into from Jun 8, 2023

Conversation

vparfonov
Copy link
Contributor

Description

This PR make code cleanup to remove the certificate handling modifications made in response to LOG-1923

/cc
/assign @jcantrill

/cherry-pick

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2023

@vparfonov: This pull request references LOG-4175 which is a valid jira issue.

In response to this:

Description

This PR make code cleanup to remove the certificate handling modifications made in response to LOG-1923

/cc
/assign @jcantrill

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2023
@jcantrill
Copy link
Contributor

Why are there so many unrelated formatting changes?

@vparfonov vparfonov force-pushed the log4175 branch 2 times, most recently from c58b58b to 6d892ef Compare June 7, 2023 18:23
…ns made for LOG-1923

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vparfonov
Copy link
Contributor Author

Why are there so many unrelated formatting changes?

fixed

@jcantrill
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cdb387b and 2 for PR HEAD b59caaf in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2023

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 787ae81 into openshift:master Jun 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants