Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-4095: fix labels with more then one dot #2058

Merged
merged 1 commit into from Jul 3, 2023
Merged

LOG-4095: fix labels with more then one dot #2058

merged 1 commit into from Jul 3, 2023

Conversation

jcantrill
Copy link
Contributor

Description

This provides an additional fix with labels that have more then one dot and slash

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 14, 2023 •
edited by openshift-ci bot

@jcantrill: This pull request references LOG-4095 which is a valid jira issue.

In response to this:

Description

This provides an additional fix with labels that have more then one dot and slash

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor Author

/cherrpick master

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@jcantrill jcantrill added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2023
@jcantrill
Copy link
Contributor Author

/retest

1 similar comment
@jcantrill
Copy link
Contributor Author

/retest

@vparfonov
Copy link
Contributor

/test e2e-target

@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2023
@cahartma
Copy link
Contributor

cahartma commented Jul 3, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 90d79c3 into openshift:release-5.7 Jul 3, 2023
10 checks passed
@jcantrill jcantrill deleted the log4095_add branch July 6, 2023 16:25
@jcantrill
Copy link
Contributor Author

/cherrypick master

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 6, 2023
Merged
@openshift-cherrypick-robot
Copy link

@jcantrill: new pull request created: #2077

In response to this:

/cherrypick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vimalk78 vimalk78 Awaiting requested review from vimalk78

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@vparfonov vparfonov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jcantrill @openshift-ci-robot @vparfonov @cahartma @openshift-cherrypick-robot @openshift-merge-robot