Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4237: add validation rule that will drop configuration for Splunk output and Fluentd collector #2059

Merged
merged 1 commit into from Jun 23, 2023

Conversation

vparfonov
Copy link
Contributor

Description

This PR addresses the issue where the configuration for Splunk output and Fluentd collector, this can lead to unexpected behavior and errors in the system, it because we not support Fluentd and Splunk integration (see https://docs.openshift.com/container-platform/4.13/logging/v5_6/logging-5-6-reference.html). To resolve this, we have implemented a new validation rule that will drop the configuration for Splunk output and Fluentd collector.

/cc
/assign

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

… output and Fluentd collector

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2023

@vparfonov: This pull request references LOG-4237 which is a valid jira issue.

In response to this:

Description

This PR addresses the issue where the configuration for Splunk output and Fluentd collector, this can lead to unexpected behavior and errors in the system, it because we not support Fluentd and Splunk integration (see https://docs.openshift.com/container-platform/4.13/logging/v5_6/logging-5-6-reference.html). To resolve this, we have implemented a new validation rule that will drop the configuration for Splunk output and Fluentd collector.

/cc
/assign

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2023
@openshift-ci openshift-ci bot requested review from syedriko and vimalk78 June 15, 2023 18:50
@vparfonov
Copy link
Contributor Author

/retest

@vparfonov
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2023

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vparfonov
Copy link
Contributor Author

/assign @jcantrill
/cc @cahartma

@cahartma
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2023
@Clee2691
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 924f716 into openshift:release-5.7 Jun 23, 2023
10 checks passed
@vparfonov
Copy link
Contributor Author

/cherry-pick master

@openshift-cherrypick-robot

@vparfonov: new pull request created: #2064

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants