Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-5.7] LOG-4368: Fix fluentd sts cloudwatch multiple roles #2100

Conversation

cahartma
Copy link
Contributor

@cahartma cahartma commented Jul 19, 2023

Description

Fix fluentd so it no longer uses ENV vars for sts credentials.

Notes:

A change to the fluentd code resulted in regression of multiple role_arn authentication, when forwarding to cloudwatch. The change was introduced in logging 5.6, while implementing vector sts for cloudwatch. A similar change will need to be made for vector, once we figure out an authentication workaround.

/cc @Clee2691 @syedriko @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2023

@cahartma: This pull request references LOG-4369 which is a valid jira issue.

In response to this:

Description

Fix fluentd so it no longer uses ENV vars for sts credentials.

Notes:

A change to the fluentd code resulted in regression of multiple role_arn authentication, when forwarding to cloudwatch. The change was introduced in logging 5.6, while implementing vector sts for cloudwatch. A similar change will need to be made for vector, once we figure out an authentication workaround.

/cc @Clee2691 @syedriko @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2023
@cahartma cahartma changed the title [release-5.7] LOG-4369: Fix fluentd sts cloudwatch multiple roles [release-5.7] LOG-4368: Fix fluentd sts cloudwatch multiple roles Jul 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2023

@cahartma: This pull request references LOG-4368 which is a valid jira issue.

In response to this:

Description

Fix fluentd so it no longer uses ENV vars for sts credentials.

Notes:

A change to the fluentd code resulted in regression of multiple role_arn authentication, when forwarding to cloudwatch. The change was introduced in logging 5.6, while implementing vector sts for cloudwatch. A similar change will need to be made for vector, once we figure out an authentication workaround.

/cc @Clee2691 @syedriko @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2023

@cahartma: This pull request references LOG-4368 which is a valid jira issue.

In response to this:

Description

Fix fluentd so it no longer uses ENV vars for sts credentials.

Notes:

A change to the fluentd code resulted in regression of multiple role_arn authentication, when forwarding to cloudwatch. The change was introduced in logging 5.6, while implementing vector sts for cloudwatch. A similar change will need to be made for vector, once we figure out an authentication workaround.

/cc @Clee2691 @syedriko @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cahartma cahartma force-pushed the LOG-4369-release-5.7-fluent-sts-cloudwatch-auth branch from 12619ae to 4a45876 Compare July 20, 2023 20:04
@jcantrill
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0698aa5 into openshift:release-5.7 Jul 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants