LOG-3570: Remove tlsSecurityProfile feature gate #2102
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@syedriko: This pull request references LOG-3570 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, syedriko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
syedriko
force-pushed
the
syedriko-log-3570
branch
from
6731ceb
to
e52b8fc
Compare
|
/test e2e-target |
1 similar comment
|
/test e2e-target |
| if o.Name == logging.OutputNameDefault && o.Type == logging.OutputTypeElasticsearch { | ||
| op[generator.MinTLSVersion] = "" | ||
| op[generator.Ciphers] = "" | ||
| } else { |
There was a problem hiding this comment.
Is this going to set tls for all other outputs? Don't you still need to check for loki here?
There was a problem hiding this comment.
This is going to set TLS version and ciphersuites for the all the outputs but the default ES, if they enable TLS.
The line I removed said if the feature gate flag is set or it's loki, [docs/features/tls_security_profile.adoc] ^^^ had this The feature gate is ignored for the default log storage of type loki. Without the feature gate, there's no need for loki exception.
For collector config gen unit tests, embedded expected config
syedriko
force-pushed
the
syedriko-log-3570
branch
from
e52b8fc
to
94eaeb7
Compare
|
@syedriko: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
merged commit 1548385
into
openshift:master
Description
Remove tlsSecurityProfile feature gate
/cc @cahartma
/assign @jcantrill
Links