Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-4240: initialize spec.visualization with ocp-console plugin, if spec.LogStore was defined as lokistack and the visualization not defined #2103

Merged
merged 1 commit into from
Jul 25, 2023
Merged

LOG-4240: initialize spec.visualization with ocp-console plugin, if spec.LogStore was defined as lokistack and the visualization not defined #2103

merged 1 commit into from
Jul 25, 2023

Conversation

vparfonov
Copy link
Contributor

Description

This PR introduce ability to initialize spec.visualization with ocp-console plugin, if LogStore was defined as lokistack and the visualization not defined

/cc
/assign @jcantrill

/cherry-pick

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 20, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-4240 which is a valid jira issue.

In response to this:

Description

This PR introduce ability to initialize spec.visualization with ocp-console plugin, if LogStore was defined as lokistack and the visualization not defined

/cc
/assign @jcantrill

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from Clee2691 and vimalk78 July 20, 2023 17:46
jcantrill
jcantrill reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

internal/migrations/migrate_collection.go Outdated Show resolved Hide resolved
internal/migrations/migrate_collection.go Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2023
@jcantrill
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@vparfonov
Copy link
Contributor Author

/test functional

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2023
@vparfonov
LOG-4240: When the LogStore is defined as lokistack and the visualiza…
c83f638 
…tion is initialized with nil, the visualization will be set to ocp-console

Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@jcantrill
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2023
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2023

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-target-minus-one c83f638 link false /test e2e-ocp-target-minus-one

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e418bc8 into openshift:master Jul 25, 2023
9 of 10 checks passed
@vparfonov vparfonov deleted the log4240 branch July 26, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@Clee2691 Clee2691 Awaiting requested review from Clee2691

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vparfonov @openshift-ci-robot @jcantrill @openshift-merge-robot