Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-3361: depend upon 'operator-sdk run' to run and deploy operator b… #2126

Closed
wants to merge 3 commits into from

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • moves the operator deployment to use operator-sdk run
  • Removes legacy catalog building and deployment
  • Updates Makefile to remove deprecated targets
  • Removes legacy bundle files and scripts

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 14, 2023

@jcantrill: This pull request references LOG-3361 which is a valid jira issue.

In response to this:

Description

This PR:

  • moves the operator deployment to use operator-sdk run
  • Removes legacy catalog building and deployment
  • Updates Makefile to remove deprecated targets
  • Removes legacy bundle files and scripts

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Aug 14, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@jcantrill
Copy link
Contributor Author

@bparees It has been a long time in coming... thank you for your contributions 😉

@bparees
Copy link
Contributor

bparees commented Aug 14, 2023

😢

@jcantrill
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2023

@jcantrill: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-target-minus-two 7ee4fb5 link false /test e2e-ocp-target-minus-two
ci/prow/e2e-target 7ee4fb5 link true /test e2e-target
ci/prow/functional 7ee4fb5 link false /test functional
ci/prow/functional-target 7ee4fb5 link true /test functional-target
ci/prow/images 7ee4fb5 link true /test images
ci/prow/e2e-ocp-target-minus-one 7ee4fb5 link false /test e2e-ocp-target-minus-one

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. midstream/Dockerfile A Dockerfile.in sync is needed with midstream needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release/5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants