LOG-4181: fix loki test flake caused by rate limiting #2127
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jcantrill: This pull request references LOG-4181 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jcantrill
force-pushed
the
log4181_on_master
branch
from
9f95d1c
to
0fb1341
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jcantrill
force-pushed
the
log4181_on_master
branch
from
0fb1341
to
b3b5c25
Compare
test/helpers/loki/receiver.go
Outdated
| @@ -26,7 +26,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| Image = "grafana/loki:2.5.0" | |||
| Image = "grafana/loki:2.8.0" | |||
There was a problem hiding this comment.
I'd just go with the latest patch version (or the one we use in Loki Operator, 2.8.3):
| Image = "grafana/loki:2.8.0" | |
| Image = "grafana/loki:2.8.4" |
|
bq. The limits seem a bit excessive. This works, but might hide an issue down the road that we then only see when something really goes wrong and even hits those limits. These limits were added based upon what I saw in the error logs of the test so they are real numbers. My concern more is to resolve the test flake and this test verifies we can write to Loki. We make no changes to Loki config outside of using the defaults which are likely not ideal. The test is intended to be an integration test that verifies connectivity between the collector and Loki. While I agree it could be tweaked better, we would need to define additional goals of the test and bullet proof it accordingly |
jcantrill
force-pushed
the
log4181_on_master
branch
from
b3b5c25
to
fb14859
Compare
|
@jcantrill: This pull request references LOG-4181 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcantrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
Description
This PR:
Links