Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-3949: Vector not releasing deleted file handles #2185

Merged
merged 1 commit into from Oct 3, 2023

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Sep 29, 2023

Description

For the kubernetes_logs vector source, override the (very large) default for the newly introduced rotate_wait_ms variable.

/cc @cahartma
/assign @jcantrill

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

For the kubernetes_logs vector source, override the (very large) default for the newly introduced rotate_wait_ms variable.

/cc @cahartma
/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2023

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

For the kubernetes_logs vector source, override the (very large) default for the newly introduced rotate_wait_ms variable.

/cc @cahartma
/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, syedriko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2023

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

For the kubernetes_logs vector source, override the (very large) default for the newly introduced rotate_wait_ms variable.

/cc @cahartma
/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

For the kubernetes_logs vector source, override the (very large) default for the newly introduced rotate_wait_ms variable.

/cc @cahartma
/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@syedriko
Copy link
Contributor Author

syedriko commented Oct 2, 2023

/test e2e-target
/test functional-target

@jcantrill
Copy link
Contributor

/lgtm

1 similar comment
@jcantrill
Copy link
Contributor

/lgtm

@jcantrill jcantrill added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023

@syedriko: This pull request references LOG-3949 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

For the kubernetes_logs vector source, override the (very large) default for the newly introduced rotate_wait_ms variable.

/cc @cahartma
/assign @jcantrill

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5a6af17 and 2 for PR HEAD f528d59 in total

@openshift-merge-robot
Copy link
Contributor

@syedriko: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-target f528d59 link unknown /test e2e-target
ci/prow/images f528d59 link unknown /test images
ci/prow/functional-target f528d59 link unknown /test functional-target

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@syedriko
Copy link
Contributor Author

syedriko commented Oct 3, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2023

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 3663f7d into openshift:master Oct 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants