LOG-4597: modify vector buffer and request to have mostly parity with…

[jcantrill]

… fluentd

Description

This PR:

• Adds buffer and request settings to all outputs for vector inorder to achieve some parity to prior releases
• Modifies http api timeout to be an int instead of string of an int

Links

• https://issues.redhat.com/browse/LOG-4597

cc @alanconway @syedriko

[openshift-ci-robot]

@jcantrill: This pull request references LOG-4597 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

… fluentd

Description

This PR:

• Adds buffer and request settings to all outputs for vector inorder to achieve some parity to prior releases
• Modifies http api timeout to be an int instead of string of an int

Links

• https://issues.redhat.com/browse/LOG-4597

cc @alanconway @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jcantrill: This pull request references LOG-4597 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

… fluentd

Description

This PR:

• Adds buffer and request settings to all outputs for vector inorder to achieve some parity to prior releases
• Modifies http api timeout to be an int instead of string of an int

Links

• https://issues.redhat.com/browse/LOG-4597

cc @alanconway @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jcantrill: This pull request references LOG-4597 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

… fluentd

Description

This PR:

• Adds buffer and request settings to all outputs for vector inorder to achieve some parity to prior releases
• Modifies http api timeout to be an int instead of string of an int

Links

• https://issues.redhat.com/browse/LOG-4597

cc @alanconway @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

/hold

[openshift-ci-robot]

@jcantrill: This pull request references LOG-4597 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

… fluentd

Description

This PR:

• Adds buffer and request settings to all outputs for vector inorder to achieve some parity to prior releases
• Modifies http api timeout to be an int instead of string of an int

Links

• https://issues.redhat.com/browse/LOG-4597

cc @alanconway @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jcantrill: This pull request references LOG-4597 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

… fluentd

Description

This PR:

• Adds buffer and request settings to all outputs for vector inorder to achieve some parity to prior releases
• Modifies http api timeout to be an int instead of string of an int

Links

• https://issues.redhat.com/browse/LOG-4597

cc @alanconway @syedriko

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

/hold cancel

[cahartma]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 5086916 and 2 for PR HEAD 96155da in total

[cahartma]

/lgtm

[alanconway]

Should be TimeoutSeconds for clarity. IIRC this is in the k8s API guidelines for time variables.
Not a blocker if it's too late to change.

[jcantrill]

The http type was released for 5.7 so there is not a place to change it. I have concerns about changing the time as-is

[cahartma]

Can we release the hold?

[alanconway]

/hold
Suggested a name change, otherwise all looks good.

[cahartma]

/hold cancel

[cahartma]

/lgtm

[openshift-ci]

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.