LOG-4676: Modify receiverport to be a simple int instead of a struct #2215
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@syedriko: This pull request references LOG-4676 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
internal/validations/clusterlogforwarder/validate_clusterlogforwarderspec.go
Outdated
Show resolved
Hide resolved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, syedriko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
syedriko
force-pushed
the
syedriko-log-4676
branch
2 times, most recently
from
9697dfc
to
711a102
Compare
syedriko
force-pushed
the
syedriko-log-4676
branch
from
711a102
to
c533b01
Compare
|
/test functional-target |
|
/lgtm |
|
@syedriko: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
ReceiverPort is defined as a complex struct which mimics the need of defining a port for a generic service. The CLO controls all aspects of the receiver so it should need to have this complexity; users should only need to define potentially the port upon which to listen. Modify the API and code to convert 'receiverPort' into an int
/cc @alanconway
/assign @jcantrill
Links