Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4706: Fluentd CrashLoopBackOff on single stack IPv6 and dual stack clusters #2230

Merged
merged 1 commit into from Nov 7, 2023

Conversation

Clee2691
Copy link
Contributor

@Clee2691 Clee2691 commented Nov 1, 2023

Description

This PR addresses the issue with collector pods crashing due to Fluentd binding an IPv6 address that include brackets ([::]) for prometheus monitoring. Fluentd v1.14.6 worked with the mentioned IPv6 address but Fluentd v5.8.0 changed the way IPv6 addresses are handled.

/cc @syedriko @cahartma
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 1, 2023

@Clee2691: This pull request references LOG-4706 which is a valid jira issue.

In response to this:

Description

This PR addresses the issue with collector pods crashing due to Fluentd binding an IPv6 address that include brackets ([::]) for prometheus monitoring. Fluentd v1.14.6 worked with the mentioned IPv6 address but Fluentd v5.8.0 changed the way IPv6 addresses are handled.

/cc @syedriko @cahartma
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Clee2691
Copy link
Contributor Author

Clee2691 commented Nov 1, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2023
@jcantrill
Copy link
Contributor

I wonder if it would be safer to use @syedriko method where it's checked in the operator and just configured explicitly in the conf?

@Clee2691
Copy link
Contributor Author

Clee2691 commented Nov 2, 2023

/retest

1 similar comment
@Clee2691
Copy link
Contributor Author

Clee2691 commented Nov 2, 2023

/retest

@jcantrill
Copy link
Contributor

/approve
/lgtm

@jcantrill
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 6, 2023
Copy link
Contributor

openshift-ci bot commented Nov 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2023
@jcantrill
Copy link
Contributor

@Clee2691 please cherrypick to master and/or 5.7 as needed

@Clee2691
Copy link
Contributor Author

Clee2691 commented Nov 6, 2023

/cherry-pick master

@openshift-cherrypick-robot

@Clee2691: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8517229 and 2 for PR HEAD 110877e in total

@Clee2691
Copy link
Contributor Author

Clee2691 commented Nov 7, 2023

/retest

Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 11563c5 into openshift:release-5.8 Nov 7, 2023
10 checks passed
@openshift-cherrypick-robot

@Clee2691: new pull request created: #2236

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants