Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4846: Adjust CLO to include the korrel8r proxy in the logging view plugin #2276

Conversation

alanconway
Copy link
Contributor

Korrel8r proxy is enabled whenever Loki view is.
Points to fixed service korrel8r in namespace korrel8r.

Keeping it simple, the role of enabling korrel8r will likely move out of CLO,
and become part of the new observability operator in future.

…w plugin

Korrel8r proxy is enabled whenever Loki view is.
Points to fixed service korrel8r in namespace korrel8r.

Keeping it simple, the role of enabling korrel8r will likely move out of CLO,
and become part of the new observability operator in future.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 30, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 30, 2023

@alanconway: This pull request references LOG-4846 which is a valid jira issue.

In response to this:

Korrel8r proxy is enabled whenever Loki view is.
Points to fixed service korrel8r in namespace korrel8r.

Keeping it simple, the role of enabling korrel8r will likely move out of CLO,
and become part of the new observability operator in future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2023
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link
Contributor

openshift-ci bot commented Nov 30, 2023

@alanconway: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3762d7f into openshift:release-5.8 Nov 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants