Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-4941: Add infrastructure annotations #2301

Merged
merged 1 commit into from
Jan 18, 2024
Merged

LOG-4941: Add infrastructure annotations #2301

merged 1 commit into from
Jan 18, 2024

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Jan 9, 2024 •
edited

Description

This PR:

  • Add infrastructure annotations

Links

cc @cahartma

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 9, 2024 •
edited by openshift-ci bot

@jcantrill: This pull request references LOG-4941 which is a valid jira issue.

In response to this:

Description

This PR:

  • Add infrastructure annotations
  • Updates the channel in the manifest

Links

cc @cahartma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill jcantrill added release/5.7 and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@openshift-ci openshift-ci bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Jan 9, 2024
cahartma
cahartma reviewed Jan 9, 2024
View reviewed changes
config/overlays/hcp/deployment_patch.yaml Outdated
Copy link
Contributor

@cahartma cahartma Jan 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the two /overlays/hcp files

cahartma
cahartma reviewed Jan 9, 2024
View reviewed changes
config/manifests/bases/clusterlogging.clusterserviceversion.yaml
Copy link
Contributor

@cahartma cahartma Jan 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundle/manifest includes version in the name, but I noticed all config/manifests have value: clusterlogging.v0.0.0 Worth updating?
line38 below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduced the changes to the minimal set like for the other branches

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 10, 2024 •
edited by openshift-ci bot

@jcantrill: This pull request references LOG-4941 which is a valid jira issue.

In response to this:

Description

This PR:

  • Add infrastructure annotations

Links

cc @cahartma

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cahartma
Copy link
Contributor

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill
Copy link
Contributor Author

/hold

5.7 freeze

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 15, 2024
@cahartma
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2024
@cahartma
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 059176a into openshift:release-5.7 Jan 18, 2024
10 checks passed
@jcantrill jcantrill deleted the log4941 branch January 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahartma cahartma cahartma left review comments

@syedriko syedriko Awaiting requested review from syedriko

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@cahartma cahartma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile A Dockerfile.in sync is needed with midstream release/5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcantrill @openshift-ci-robot @cahartma