Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch nil ptr exceptions with enabled Forwarder and empty Collection #2313

Merged

Commits on Feb 19, 2024

  1. Fix 'make run' after refactor to operator-sdk

    Signed-off-by: Andreas Karis <ak.karis@gmail.com>
    andreaskaris committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    56d46f5 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Catch nil ptr exceptions with enabled Forwarder and empty Collection

    When the Forwarder is enabled, make sure that
    clusterLogging.Spec.Collection is non nil to avoid nil pointer
    exceptions from occurring.
    
    Signed-off-by: Andreas Karis <ak.karis@gmail.com>
    andreaskaris committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c11c9ef View commit details
    Browse the repository at this point in the history
  2. Synchronize ClusterLogForwarder Status conditions, don't replace them

    Replacing the CLF Status field causes the resourceVersion to be updated
    constantly due to changing timestamps in Status conditions. This in
    turn leads to an infinite reconciliation loop. Instead, synchronize all
    status conditions so that timestamps remain unchanged if conditions are
    not changed.
    
    Signed-off-by: Andreas Karis <ak.karis@gmail.com>
    andreaskaris committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    d1af0bb View commit details
    Browse the repository at this point in the history
  3. Update ClusterLogForwarder status when ClusterLogging becomes valid

    After a valid ClusterLogForwarder and an invalid ClusterLogging resource
    are created, the ClusterLogForwarder's status will show that the CLF is
    not available. When the ClusterLogging CR is then changes to a valid
    configuration, the CLF's status should reflect that everything is o.k.
    now.
    
    Signed-off-by: Andreas Karis <ak.karis@gmail.com>
    andreaskaris committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    61c1e1a View commit details
    Browse the repository at this point in the history