-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-4817: Remove raw secrets from must-gather and update dir structure #2317
LOG-4817: Remove raw secrets from must-gather and update dir structure #2317
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahartma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
@cahartma: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is already in logging must-gather 5.9, asking for backport to 5.8: /cherry-pick release-5.8 |
@oarribas: #2317 failed to apply on top of branch "release-5.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@oarribas please clone JIRA for backport |
@jcantrill , cloned. Is the manual clone of the JIRA required because the cherry-pick failed? |
Description
For LOG-4817 the best solution is to remove this file from the 'oc get' under '/cluster-logging/clo' directory. There is already a list of sanitized secrets listed under each namespace.
The other changes are from PR 2257 below, are aligning docs and directory structure to be used with the 'omc' tool.
/cc @vparfonov @Clee2691
/assign @jcantrill
Links
clusterlogging
andclusterlogforwarder
with inspect (#5) #2257