Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4817: Remove raw secrets from must-gather and update dir structure #2317

Merged

Conversation

cahartma
Copy link
Contributor

@cahartma cahartma commented Jan 18, 2024

Description

For LOG-4817 the best solution is to remove this file from the 'oc get' under '/cluster-logging/clo' directory. There is already a list of sanitized secrets listed under each namespace.
The other changes are from PR 2257 below, are aligning docs and directory structure to be used with the 'omc' tool.

/cc @vparfonov @Clee2691
/assign @jcantrill

Links

Copy link
Contributor

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2024
@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e5237d4 and 2 for PR HEAD 84005b7 in total

@cahartma
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4463eee into openshift:master Jan 25, 2024
10 checks passed
@cahartma cahartma changed the title Remove raw secrets from must-gather and update dir structure LOG-4817: Remove raw secrets from must-gather and update dir structure Jan 26, 2024
@oarribas
Copy link
Contributor

This is already in logging must-gather 5.9, asking for backport to 5.8:

/cherry-pick release-5.8

@openshift-cherrypick-robot

@oarribas: #2317 failed to apply on top of branch "release-5.8":

Applying: Remove raw secrets from must-gather and update dir structure
.git/rebase-apply/patch:53: trailing whitespace.
   │  │  │  └── [clf_name.yaml]   
.git/rebase-apply/patch:68: trailing whitespace.
   │  │  │           └── previous.log   
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	must-gather/collection-scripts/gather
M	must-gather/collection-scripts/gather_cluster_logging_operator_resources
Falling back to patching base and 3-way merge...
Auto-merging must-gather/collection-scripts/gather_cluster_logging_operator_resources
CONFLICT (content): Merge conflict in must-gather/collection-scripts/gather_cluster_logging_operator_resources
Auto-merging must-gather/collection-scripts/gather
CONFLICT (content): Merge conflict in must-gather/collection-scripts/gather
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Remove raw secrets from must-gather and update dir structure
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

This is already in logging must-gather 5.9, asking for backport to 5.8:

/cherry-pick release-5.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor

@oarribas please clone JIRA for backport

@oarribas
Copy link
Contributor

@jcantrill , cloned.

Is the manual clone of the JIRA required because the cherry-pick failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants