LOG-4962: fix outputs with no secret adding bearer token

[jcantrill]

Description

This PR:

• fixes the case where outputs which define no secret still generate config with the legacy token secret
• Adds a function for secret special handling of generated default loki outputs

Links

• https://issues.redhat.com/browse/LOG-4962
• forward port of LOG-4962: fix outputs with no secret adding bearer token #2307

cc @xperimental @Clee2691

[openshift-ci-robot]

@jcantrill: This pull request references LOG-4962 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

• fixes the case where outputs which define no secret still generate config with the legacy token secret
• Adds a function for secret special handling of generated default loki outputs

Links

• https://issues.redhat.com/browse/LOG-4962
• forward port of LOG-4962: fix outputs with no secret adding bearer token #2307

cc @xperimental @Clee2691

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@jcantrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/functional	dce0b47	link	false	/test functional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vparfonov]

/lgtm