Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-4943: Enhance Infrastructure permissions to support application log collection #2332

Merged
merged 1 commit into from Feb 1, 2024
Merged

LOG-4943: Enhance Infrastructure permissions to support application log collection #2332

merged 1 commit into from Feb 1, 2024

Conversation

Clee2691
Copy link
Contributor

Description

This PR adds a permission validation for ClusterLogForwarderss that spec an application input with infrastructure namespaces.

Infrastructure namespaces are:

  1. default
  2. openshift*
  3. kube*

In addition, since infra namespaces were excluded by default, this changes the behavior when a user includes an infra namespace by removing it from the exclude list.

/cc @cahartma @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2024 •
edited by openshift-ci bot

@Clee2691: This pull request references LOG-4943 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR adds a permission validation for ClusterLogForwarderss that spec an application input with infrastructure namespaces.

Infrastructure namespaces are:

  1. default
  2. openshift*
  3. kube*

In addition, since infra namespaces were excluded by default, this changes the behavior when a user includes an infra namespace by removing it from the exclude list.

/cc @cahartma @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Clee2691
Copy link
Contributor Author

/test all

@Clee2691 Clee2691 changed the title LOG-4943: Enhance Infrastructure permissions to support application log collection [WIP] LOG-4943: Enhance Infrastructure permissions to support application log collection Jan 31, 2024
jcantrill
jcantrill reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

internal/generator/vector/input/viaq.go Outdated Show resolved Hide resolved
internal/generator/vector/input/viaq.go Outdated Show resolved Hide resolved
internal/generator/vector/input/viaq_application_with_infra_includes_excludes.toml Show resolved Hide resolved
internal/generator/vector/input/viaq_test.go Show resolved Hide resolved
internal/validations/clusterlogforwarder/inputs/validate_test.go Show resolved Hide resolved
internal/validations/clusterlogforwarder/validate_clusterlogforwarder_service_account_test.go Show resolved Hide resolved
@jcantrill
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Clee2691 Clee2691 marked this pull request as ready for review January 31, 2024 17:31
@Clee2691 Clee2691 changed the title [WIP] LOG-4943: Enhance Infrastructure permissions to support application log collection LOG-4943: Enhance Infrastructure permissions to support application log collection Jan 31, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@Clee2691
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@jcantrill jcantrill mentioned this pull request Jan 31, 2024
Merged
@Clee2691
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 1, 2024

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9fe9fdd into openshift:master Feb 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@cahartma cahartma Awaiting requested review from cahartma

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@jcantrill jcantrill

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Clee2691 @openshift-ci-robot @jcantrill