-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-5034: Remove required field from install on STS and ROSA #2335
LOG-5034: Remove required field from install on STS and ROSA #2335
Conversation
@cahartma: This pull request references LOG-5034 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@cahartma: This pull request references LOG-5034 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahartma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cahartma: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
825e534
into
openshift:master
Description
LOG-5034 was created to remove the annotation which creates a required "role_arn" at install of our logging operator. This will remove us from the "token enabled" list in the operator hub, but the resulting required field is more confusing than not being included in the list.
This can be backported once verified.
Ultimately, we need to come up with a better solution to the epic requiring this "role_arn at install" feature. re: https://issues.redhat.com/browse/LOG-4154
/cc @Clee2691 @vparfonov
/assign @jcantrill
Links