Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-5034: Remove required field from install on STS and ROSA #2335

Conversation

cahartma
Copy link
Contributor

@cahartma cahartma commented Feb 2, 2024

Description

LOG-5034 was created to remove the annotation which creates a required "role_arn" at install of our logging operator. This will remove us from the "token enabled" list in the operator hub, but the resulting required field is more confusing than not being included in the list.
This can be backported once verified.
Ultimately, we need to come up with a better solution to the epic requiring this "role_arn at install" feature. re: https://issues.redhat.com/browse/LOG-4154

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2024

@cahartma: This pull request references LOG-5034 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

LOG-5034 was created to remove the annotation which creates a required "role_arn" at install of our logging operator. This will remove us from the "token enabled" list in the operator hub, but the resulting required field is more confusing than not being included in the list.
This can be backported once verified.
Ultimately, we need to come up with a better solution to the epic requiring this "role_arn at install" feature. re: https://issues.redhat.com/browse/LOG-4154

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 2, 2024

@cahartma: This pull request references LOG-5034 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

LOG-5034 was created to remove the annotation which creates a required "role_arn" at install of our logging operator. This will remove us from the "token enabled" list in the operator hub, but the resulting required field is more confusing than not being included in the list.
This can be backported once verified.
Ultimately, we need to come up with a better solution to the epic requiring this "role_arn at install" feature. re: https://issues.redhat.com/browse/LOG-4154

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

@cahartma: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional e4aec91 link false /test functional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 825e534 into openshift:master Feb 2, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants