LOG-4606: create dev doc for Azure Monitor log forwarding integration #2347
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vparfonov: This pull request references LOG-4606 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target either version "4.8." or "openshift-4.8.", but it targets "Logging 5.9.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @jcantrill |
| kind: "ClusterLogForwarder" | ||
| spec: | ||
| outputs: | ||
| - name: azureLogAnalyticsApp |
There was a problem hiding this comment.
Same nit as I mentioned with the CEE slides. Match case with our other docs, kebab-case for the values of names. Low priority if you agree.
vparfonov
force-pushed
the
log4606-docs
branch
from
07b6c77
to
a743251
Compare
| oc create secret generic azure-secret -n openshift-logging --from-literal=shared_key='<shared_key>' | ||
| ---- | ||
|
|
||
| . Create a Cluster Logging instance with collection `type: vector`: |
There was a problem hiding this comment.
Let's exclude this since it is only supported in vector and this is not required as part of mCLF
vparfonov
force-pushed
the
log4606-docs
branch
from
a743251
to
1a986b9
Compare
| oc create secret generic azure-secret -n openshift-logging --from-literal=shared_key='<shared_key>' | ||
| ---- | ||
|
|
||
| . Create a Cluster Logging instance: |
There was a problem hiding this comment.
I still see this section which we can remove regarding ClusterLogging
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
|
/lgtm |
|
@vparfonov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vparfonov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Description
/cc
/assign
/cherry-pick
Links