Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-5174 & LOG-5177 & LOG-5178 && LOG-5179 #2388

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Clee2691
Copy link
Contributor

@Clee2691 Clee2691 commented Mar 6, 2024

Description

This PR fixes 4 issues:

  1. Allow compression to be set for Elasticsearch. [1]
  2. Allow compression to be set for Kafka as well as add a new compression type lz4. [2]
  3. Added validation for GCP sink because it does not support compression. [3]
  4. Fix CLF validation for invalid tune specs. Will now invalidate the CLF if any tune specs are invalid. [4]

/cc @cahartma @vparfonov
/assign @jcantrill

Links

@Clee2691
Copy link
Contributor Author

Clee2691 commented Mar 6, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 7, 2024
@jcantrill
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit ad9fb0f into openshift:master Mar 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants