LOG-4910: remove collector daemonset only if 'Not authorized to collect' error occurs #2425
Conversation
…ct' error occurs Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@vparfonov: This pull request references LOG-4910 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, vparfonov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/cherrypick release-5.9 |
|
@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-target |
|
/override ci/prow/e2e-ocp-target-minus-one |
|
/override ci/prow/e2e-ocp-target-minus-two |
|
@jcantrill: Overrode contexts on behalf of jcantrill: ci/prow/e2e-ocp-target-minus-one In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jcantrill: Overrode contexts on behalf of jcantrill: ci/prow/e2e-ocp-target-minus-two In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-target |
|
/hold Revision f9cf073 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-target |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/cherry-pick release-5.9 |
|
@vparfonov: once the present PR merges, I will cherry-pick it on top of release-5.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-target |
|
/retest |
|
/hold Revision f9cf073 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test e2e-target |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
@vparfonov: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@jcantrill: new pull request created: #2456 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
This PR addresses the behavior of the reconciliation process, specifically focusing on error handling: the reconciler should skip all errors and leave the collector instance unchanged, only removing it in the event of a
Not authorized to collecterror./cc @Clee2691 @cahartma
/assign @jcantrill
/cherry-pick
Links