Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-5322 & LOG-5323 segfaults if PrunfilterSpec or DropTestsSpec not spec'd #2426

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

Clee2691
Copy link
Contributor

@Clee2691 Clee2691 commented Apr 1, 2024

Description

This PR adds a nil check for drop and prune filters during validation and will raise a validation error if the appropriate FilterTypeSpec is not defined.

/cc @cahartma @vparfonov
/assign @jcantrill

Links

  • JIRA:
  1. https://issues.redhat.com/browse/LOG-5322
  2. https://issues.redhat.com/browse/LOG-5323

@Clee2691
Copy link
Contributor Author

Clee2691 commented Apr 1, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2024
@Clee2691
Copy link
Contributor Author

Clee2691 commented Apr 4, 2024

/retest

3 similar comments
@Clee2691
Copy link
Contributor Author

Clee2691 commented Apr 4, 2024

/retest

@Clee2691
Copy link
Contributor Author

Clee2691 commented Apr 4, 2024

/retest

@Clee2691
Copy link
Contributor Author

Clee2691 commented Apr 5, 2024

/retest

@jcantrill
Copy link
Contributor

/hold cancel
/approve
/lgtm

@jcantrill
Copy link
Contributor

/cherrypick release-5.9

@openshift-cherrypick-robot

@jcantrill: once the present PR merges, I will cherry-pick it on top of release-5.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-5.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@jcantrill
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
Copy link
Contributor

openshift-ci bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5b4f827 and 2 for PR HEAD 949fc46 in total

@jcantrill
Copy link
Contributor

/retest

5 similar comments
@Clee2691
Copy link
Contributor Author

/retest

@Clee2691
Copy link
Contributor Author

/retest

@Clee2691
Copy link
Contributor Author

/retest

@Clee2691
Copy link
Contributor Author

/retest

@Clee2691
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 17, 2024

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit dc12129 into openshift:master Apr 17, 2024
10 checks passed
@openshift-cherrypick-robot

@jcantrill: new pull request created: #2434

In response to this:

/cherrypick release-5.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants