New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOG-5108: Add 5.9.0 container image to must-gather annotation #2436
LOG-5108: Add 5.9.0 container image to must-gather annotation #2436
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cahartma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cahartma: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -135,6 +135,7 @@ metadata: | |||
operatorframework.io/cluster-monitoring: "true" | |||
operatorframework.io/suggested-namespace: openshift-logging | |||
operators.openshift.io/infrastructure-features: '["disconnected","proxy-aware"]' | |||
operators.openshift.io/must-gather-image: registry.redhat.io/openshift-logging/cluster-logging-rhel9-operator@sha256:b3a09d6dfc5109cd5d3ebf24201f9d0549d77f8965907c1b6b15faba15c767eb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an upstream repo and this should point to the upstream image. Given this annotation is meaningless (I think) to the upstream version of the bundle, I would propose simply fixing it in productization scripts and forgo making any change here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look at incorporating this into midstream.
@cahartma: This pull request references LOG-5108 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Description
Add the latest CLO container image to the bundle annotation, to accommodate the new
--all-images
flag. This should eventually go into a CPaaS file?... so we can keep the image updated. For now, the latest from the container catalog should be good. Will need to be in 6.0 release as well./cc @Clee2691 @vparfonov
/assign @jcantrill
Links