LOG-5572: Update obs conditions to meet enhancement #2518
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@jcantrill: This pull request references LOG-5572 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jcantrill
added
release/6.0
and removed
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
| @@ -14,10 +14,6 @@ limitations under the License. | |||
|
|
|||
| package v1 | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
only the declaration of constants remained in this file
There was a problem hiding this comment.
Correct. For now I'm certain these are still required. The re-definitions follows the pattern recommended for API conditions and allows us to use the existing kube types
|
/lgtm |
|
@jcantrill: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR:
Links
https://issues.redhat.com/browse/LOG-5572
cc @vparfonov @Clee2691 @cahartma