Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-5649: Refactor SA permissions for obs api #2552

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jcantrill
Copy link
Contributor

Description

This PR:

  • refactors the SA permissions validations for the OBS api

Links

https://issues.redhat.com/browse/LOG-5649

cc @Clee2691 @vparfonov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2024

@jcantrill: This pull request references LOG-5649 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR:

  • refactors the SA permissions validations for the OBS api

Links

https://issues.redhat.com/browse/LOG-5649

cc @Clee2691 @vparfonov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcantrill jcantrill added release/6.0 and removed jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 12, 2024
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2024
Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

@jcantrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@cahartma cahartma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7fc57e7 into openshift:master Jun 13, 2024
7 checks passed
@jcantrill jcantrill deleted the log5649 branch June 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release/6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants