Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1768474: Remove collector example from CSV #279

Merged
merged 1 commit into from Nov 14, 2019

Conversation

jcantrill
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 5, 2019
@openshift-ci-robot
Copy link

@jcantrill: This pull request references Bugzilla bug 1768474, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1768474: Remove collector example from CSV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill added release/4.3 and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 5, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2019
@jcantrill jcantrill added kind/bug Categorizes issue or PR as related to a bug. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@richm
Copy link
Contributor

richm commented Nov 5, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@richm
Copy link
Contributor

richm commented Nov 5, 2019

/test e2e-operator

1 similar comment
@jcantrill
Copy link
Contributor Author

/test e2e-operator

@richm
Copy link
Contributor

richm commented Nov 5, 2019

/retest

@JAORMX
Copy link
Contributor

JAORMX commented Nov 6, 2019

Oh.... it's failing some collector test:

 + go test ./test/e2e/ -root=/go/src/github.com/openshift/cluster-logging-operator -kubeconfig=/tmp/admin.kubeconfig -globalMan /tmp/tmp.FwAVFBmB3L -namespacedMan /tmp/tmp.tdz7K43Fjm -v -parallel=1 -singleNamespace
=== RUN   TestClusterLogging
=== RUN   TestClusterLogging/collectors
=== RUN   TestClusterLogging/collectors/fluentd
--- FAIL: TestClusterLogging (354.80s)
    --- FAIL: TestClusterLogging/collectors (352.45s)
        --- FAIL: TestClusterLogging/collectors/fluentd (292.45s)
        	clusterlogging_test.go:162: Initializing cluster resources...
        	client.go:57: resource type ServiceAccount with namespace/name (openshift-logging/cluster-logging-operator) created
        	client.go:57: resource type Role with namespace/name (openshift-logging/cluster-logging-operator) created
        	client.go:57: resource type RoleBinding with namespace/name (openshift-logging/cluster-logging-operator) created
        	client.go:57: resource type ClusterRole with namespace/name (openshift-logging/cluster-logging-operator) created
        	wait_util.go:55: Waiting for availability of kibana deployment
        	wait_util.go:55: Waiting for availability of kibana deployment
        	wait_util.go:55: Waiting for availability of kibana deployment
        	wait_util.go:55: Waiting for availability of kibana deployment
        	wait_util.go:55: Waiting for availability of kibana deployment
        	clusterlogging_test.go:65: timed out waiting for the condition
        	client.go:75: resource type ClusterLogging with namespace/name (openshift-logging/instance) successfully deleted
        	client.go:75: resource type Deployment with namespace/name (openshift-logging/elasticsearch-operator) successfully deleted
        	client.go:75: resource type ClusterRoleBinding with namespace/name (openshift-logging/elasticsearch-operator) successfully deleted
        	client.go:75: resource type ClusterRole with namespace/name (openshift-logging/elasticsearch-operator) successfully deleted
        	client.go:75: resource type ServiceAccount with namespace/name (openshift-logging/elasticsearch-operator) successfully deleted
        	client.go:75: resource type Deployment with namespace/name (openshift-logging/cluster-logging-operator) successfully deleted
        	client.go:75: resource type ClusterRoleBinding with namespace/name (openshift-logging/cluster-logging-operator) successfully deleted
        	client.go:75: resource type ClusterRole with namespace/name (openshift-logging/cluster-logging-operator) successfully deleted
        	client.go:75: resource type RoleBinding with namespace/name (openshift-logging/cluster-logging-operator) successfully deleted
        	client.go:75: resource type Role with namespace/name (openshift-logging/cluster-logging-operator) successfully deleted
        	client.go:75: resource type ServiceAccount with namespace/name (openshift-logging/cluster-logging-operator) successfully deleted
FAIL
FAIL	github.com/openshift/cluster-logging-operator/test/e2e	356.070s 

@jcantrill
Copy link
Contributor Author

/test e2e-operator

1 similar comment
@richm
Copy link
Contributor

richm commented Nov 7, 2019

/test e2e-operator

@jcantrill
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 7, 2019
@jcantrill
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor Author

/test e2e-operator

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2019
@ewolinetz
Copy link
Contributor

the test failed waiting for the CLO pod to be ready

         	wait_util.go:64: Waiting for full availability of cluster-logging-operator deployment (0/1)
        	clusterlogging_test.go:61: timed out waiting for the condition 

@ewolinetz
Copy link
Contributor

once we fix the tests i'll add a lgtm

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2019
@jcantrill
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill,richm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a1de55f into openshift:master Nov 14, 2019
@openshift-ci-robot
Copy link

@jcantrill: All pull requests linked via external trackers have merged. Bugzilla bug 1768474 has been moved to the MODIFIED state.

In response to this:

Bug 1768474: Remove collector example from CSV

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill deleted the 1768474 branch November 14, 2019 14:40
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
Bug 1768474: Remove collector example from CSV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release/4.3 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants