Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1768685: Improve missing secret message #280

Merged
merged 1 commit into from Nov 5, 2019
Merged

Bug 1768685: Improve missing secret message #280

merged 1 commit into from Nov 5, 2019

Conversation

jcantrill
Copy link
Contributor

@jcantrill jcantrill added release/4.3 kind/bug Categorizes issue or PR as related to a bug. labels Nov 5, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 5, 2019
@openshift-ci-robot
Copy link

@jcantrill: This pull request references Bugzilla bug 1768685, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1768685: Improve missing secret message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2019
richm
richm reviewed Nov 5, 2019
View reviewed changes
pkg/k8shandler/certificates.go Outdated
@@ -68,7 +68,7 @@ func (clusterRequest *ClusterLoggingRequest) extractSecretToFile(secretName stri

// check to see if the map value exists
if !ok {
logger.Infof("No secret data %q found", key)
logger.Warnf("No secret data %q found. Please be aware but likely not an issue for deprecated keys: app-ca,app-key,app-cert,infra-ca,infra-key,infra-cert", key)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then why not make the message Info level for deprecated keys, but Warn level for everything else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better?

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2019
richm
richm approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, richm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a4c5b8f into openshift:master Nov 5, 2019
@openshift-ci-robot
Copy link

@jcantrill: All pull requests linked via external trackers have merged. Bugzilla bug 1768685 has been moved to the MODIFIED state.

In response to this:

Bug 1768685: Improve missing secret message

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#280 from jcantrill/1768685
5fe0dd7 
Bug 1768685: Improve missing secret message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richm richm richm approved these changes

@nhosoi nhosoi Awaiting requested review from nhosoi

Assignees

@richm richm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release/4.3 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcantrill @openshift-ci-robot @richm @openshift-merge-robot