New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1793551: image-references: remove promtail #538
bug 1793551: image-references: remove promtail #538
Conversation
@sosiouxme: This pull request references Bugzilla bug 1793551, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcantrill, sosiouxme The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sosiouxme: All pull requests linked via external trackers have merged: openshift/cluster-logging-operator#459, openshift/cluster-logging-operator#538. Bugzilla bug 1793551 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bug 1793551: image-references: remove promtail
I think I misunderstood the point of this file, thinking something outside ART cared about it. If we're not looking to replace promtail downstream, I don't see a point in keeping it here -- it just forces us to look up an image and not do anything with it.
I think removing it would be a better solution for https://bugzilla.redhat.com/show_bug.cgi?id=1793551