Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1793551: image-references: remove promtail #538

Merged

Conversation

sosiouxme
Copy link
Member

I think I misunderstood the point of this file, thinking something outside ART cared about it. If we're not looking to replace promtail downstream, I don't see a point in keeping it here -- it just forces us to look up an image and not do anything with it.

I think removing it would be a better solution for https://bugzilla.redhat.com/show_bug.cgi?id=1793551

@sosiouxme sosiouxme changed the title image-references: remove promtail bug 1793551: image-references: remove promtail May 22, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label May 22, 2020
@openshift-ci-robot
Copy link

@sosiouxme: This pull request references Bugzilla bug 1793551, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1793551: image-references: remove promtail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 22, 2020
@jcantrill
Copy link
Contributor

/approve

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7b1a776 into openshift:master May 22, 2020
@openshift-ci-robot
Copy link

@sosiouxme: All pull requests linked via external trackers have merged: openshift/cluster-logging-operator#459, openshift/cluster-logging-operator#538. Bugzilla bug 1793551 has been moved to the MODIFIED state.

In response to this:

bug 1793551: image-references: remove promtail

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sosiouxme sosiouxme deleted the 20200522-remove-promtail branch May 22, 2020 14:34
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
bug 1793551: image-references: remove promtail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants