Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-965: remove username and password from fluentd conf #793

Merged
merged 1 commit into from Nov 18, 2020
Merged

LOG-965: remove username and password from fluentd conf #793

merged 1 commit into from Nov 18, 2020

Conversation

vparfonov
Copy link
Contributor

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

Description

Remove from configuration default username and password

/cc
/assign @jcantrill

/cherry-pick

Links

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2020
@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vparfonov vparfonov changed the title LOG-965: remove username and password from fluentd conf WIP: LOG-965: remove username and password from fluentd conf Nov 16, 2020
@vparfonov vparfonov marked this pull request as ready for review November 16, 2020 14:38
@vparfonov
Copy link
Contributor Author

/retest

1 similar comment
@vparfonov
Copy link
Contributor Author

/retest

jcantrill
jcantrill reviewed Nov 16, 2020
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2020
@vparfonov
remove username and password from fluentd conf
6fd3388 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vimalk78
Copy link
Contributor

/retest

@vparfonov vparfonov changed the title WIP: LOG-965: remove username and password from fluentd conf LOG-965: remove username and password from fluentd conf Nov 18, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2020
igor-karpukhin
igor-karpukhin approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igor-karpukhin, jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@vparfonov
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit b032252 into openshift:master Nov 18, 2020
@vparfonov vparfonov deleted the rmUserPass branch November 18, 2020 21:42
@vparfonov
Copy link
Contributor Author

/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link

@vparfonov: new pull request created: #802

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 18, 2020
Merged
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#793 from vparfonov/rmUserPass
8d8ead7 
LOG-965: remove username and password from fluentd conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill left review comments

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees

@igor-karpukhin igor-karpukhin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vparfonov @openshift-ci-robot @vimalk78 @openshift-cherrypick-robot @igor-karpukhin @jcantrill @openshift-merge-robot