Bug 1942609: removing logic to control replicas for kibana #998
Conversation
openshift-ci-robot
added
bugzilla/severity-low
|
@ewolinetz: This pull request references Bugzilla bug 1942609, which is valid. 1 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anli@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/lgtm |
| var ( | ||
| zeroInt = int32(0) | ||
| twoInt = int32(2) | ||
| ) | ||
|
|
There was a problem hiding this comment.
| var ( | |
| zeroInt = int32(0) | |
| twoInt = int32(2) | |
| ) | |
| func NewInt(val int) *int{ | |
| x := val | |
| return &x | |
| } |
| Spec: logging.ClusterLoggingSpec{ | ||
| Visualization: &logging.VisualizationSpec{ | ||
| KibanaSpec: logging.KibanaSpec{ | ||
| Replicas: &zeroInt, |
There was a problem hiding this comment.
| Replicas: &zeroInt, | |
| Replicas: NewInt(0), |
| Spec: logging.ClusterLoggingSpec{ | ||
| Visualization: &logging.VisualizationSpec{ | ||
| KibanaSpec: logging.KibanaSpec{ | ||
| Replicas: &twoInt, |
There was a problem hiding this comment.
| Replicas: &twoInt, | |
| Replicas: NewInt(2), |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, igor-karpukhin, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knobunc
added
the
cherry-pick-approved
Description
Manual cherry-pick of #965
/cc @jcantrill @igor-karpukhin
Links