Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-11225: Update isNodeClientCert to allow for new key usages #186

Merged
merged 1 commit into from Apr 5, 2023
Merged

OCPBUGS-11225: Update isNodeClientCert to allow for new key usages #186

merged 1 commit into from Apr 5, 2023

Conversation

rphillips
Copy link
Contributor

We missed the client cert path in #184.

@openshift-ci openshift-ci bot requested review from elmiko and RadekManak April 4, 2023 18:59
@rphillips
Copy link
Contributor Author

/retest-required

JoelSpeed
JoelSpeed reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2023
@bertinatto
Copy link
Member

/retitle OCPBUGS-11225: Update isNodeClientCert to allow for new key usages

@openshift-ci openshift-ci bot changed the title update isNodeClientCert to allow for new key usages OCPBUGS-11225: Update isNodeClientCert to allow for new key usages Apr 4, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 4, 2023
@openshift-ci-robot
Copy link
Contributor

@rphillips: This pull request references Jira Issue OCPBUGS-11225, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We missed the client cert path in #184.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 4, 2023
@openshift-ci-robot
Copy link
Contributor

@bertinatto: This pull request references Jira Issue OCPBUGS-11225, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rioliu-rh

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from rioliu-rh April 4, 2023 19:25
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d915d12 and 2 for PR HEAD 0e1685e in total

@bertinatto
Copy link
Member

/retest-required

1 similar comment
@bertinatto
Copy link
Member

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 5, 2023

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator 0e1685e link false /test e2e-azure-operator
ci/prow/e2e-gcp-operator 0e1685e link false /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a718c29 into openshift:master Apr 5, 2023
7 of 9 checks passed
@openshift-ci-robot
Copy link
Contributor

@rphillips: Jira Issue OCPBUGS-11225: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-11225 has been moved to the MODIFIED state.

In response to this:

We missed the client cert path in #184.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Apr 5, 2023

/cherry-pick release-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 5, 2023
Merged
@openshift-cherrypick-robot
Copy link

@soltysh: new pull request created: #187

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 12, 2023
Merged
carbonin added a commit to carbonin/assisted-service that referenced this pull request Jun 27, 2023
@carbonin
Don't require key encipherment usage for approving CSRs
6d93fde 
As of OCP 4.14 this isn't present in new node CSRs.

Before this change day-2 worker node CSRs in non-baremetal 4.14
spoke clusters would not get approved because of the mismatch in usages.

Resolves https://issues.redhat.com/browse/OCPBUGS-15152

Analogous changes in cluster-machine-approver:
openshift/cluster-machine-approver#184
openshift/cluster-machine-approver#186
openshift/cluster-machine-approver#189
@carbonin carbonin mentioned this pull request Jun 27, 2023
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@elmiko elmiko Awaiting requested review from elmiko

@RadekManak RadekManak Awaiting requested review from RadekManak

@rioliu-rh rioliu-rh Awaiting requested review from rioliu-rh

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rphillips @bertinatto @openshift-ci-robot @soltysh @openshift-cherrypick-robot @JoelSpeed @openshift-merge-robot